Add Support to Generate GraphQL Schema for Local Service Variable Declaration #1704

zetcco · 2024-01-09T13:02:20Z

Purpose

Examples

This improvement enables to generate GraphQL Schema for the following locally defined backendService service object.

import ballerina/lang.runtime;
import ballerina/graphql;

public function main() returns error? {
    // local service variable declaration
    graphql:Service backendService = service object {
        resource function get greeting() returns string {
            return "Hello, World";
        }
    };
    
    graphql:Listener serverEP = check new(4000);
    check serverEP.attach(backendService, "graphql");
    check serverEP.'start();
    runtime:registerListener(serverEP);
}

Checklist

Linked to an issue
Updated the changelog
Added tests
Updated the spec
Checked native-image compatibility
No commons package changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)
No compiler package changes (if there are any, please update the GraphQL version in Ballerina dev tools)

CLAassistant · 2024-01-09T13:02:26Z

All committers have signed the CLA.

.../src/main/java/io/ballerina/stdlib/graphql/compiler/LocalLevelServiceObjectAnalysisTask.java

...test/resources/ballerina_sources/generator_tests/25_local_graphql_service_object/service.bal

.../src/main/java/io/ballerina/stdlib/graphql/compiler/LocalLevelServiceObjectAnalysisTask.java

codecov · 2024-01-10T03:52:30Z

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e7e4061) 86.47% compared to head (121cb1c) 86.32%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
...raphql/compiler/ObjectConstructorAnalysisTask.java	80.76%	2 Missing and 3 partials ⚠️
...mpiler/schema/generator/GraphqlSourceModifier.java	98.07%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1704      +/-   ##
============================================
- Coverage     86.47%   86.32%   -0.16%     
- Complexity      762      771       +9     
============================================
  Files           129      130       +1     
  Lines          9094     9153      +59     
  Branches       3563     3569       +6     
============================================
+ Hits           7864     7901      +37     
- Misses          923      948      +25     
+ Partials        307      304       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...test/resources/ballerina_sources/generator_tests/25_local_graphql_service_object/service.bal

compiler-plugin/src/main/java/io/ballerina/stdlib/graphql/compiler/GraphqlCodeModifier.java

.../src/main/java/io/ballerina/stdlib/graphql/compiler/LocalLevelServiceObjectAnalysisTask.java

...c/main/java/io/ballerina/stdlib/graphql/compiler/schema/generator/GraphqlSourceModifier.java

...test/resources/ballerina_sources/generator_tests/25_local_graphql_service_object/service.bal

ballerina-tests/Dependencies.toml

...resources/ballerina_sources/generator_tests/25_local_service_object_declarations/service.bal

...es/ballerina_sources/generator_tests/26_object_field_service_object_declarations/service.bal

.../test/resources/ballerina_sources/generator_tests/27_inline_service_declarations/service.bal

ThisaruGuruge

Shall we add test in the ballerina-tests module, so that we can test the runtime as well?

sonarqubecloud · 2024-01-22T06:15:54Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

zetcco added 4 commits January 9, 2024 16:39

[Automated] Update the native jar versions

c18bc98

[Automated] Update the native jar versions

8256578

Add support to gen schema from local service obj

2f4f4b9

Update changelog

8c502a2

zetcco requested review from shafreenAnfar, ThisaruGuruge, DimuthuMadushan and MohamedSabthar as code owners January 9, 2024 13:02

Add copyright and license

4667b02

SachinAkash01 reviewed Jan 9, 2024

View reviewed changes

.../src/main/java/io/ballerina/stdlib/graphql/compiler/LocalLevelServiceObjectAnalysisTask.java Outdated Show resolved Hide resolved

SachinAkash01 reviewed Jan 9, 2024

View reviewed changes

...test/resources/ballerina_sources/generator_tests/25_local_graphql_service_object/service.bal Outdated Show resolved Hide resolved

Update license header

cbd4549

SachinAkash01 reviewed Jan 9, 2024

View reviewed changes

...test/resources/ballerina_sources/generator_tests/25_local_graphql_service_object/service.bal Outdated Show resolved Hide resolved

ayeshLK reviewed Jan 9, 2024

View reviewed changes

.../src/main/java/io/ballerina/stdlib/graphql/compiler/LocalLevelServiceObjectAnalysisTask.java Outdated Show resolved Hide resolved

ayeshLK reviewed Jan 9, 2024

View reviewed changes

.../src/main/java/io/ballerina/stdlib/graphql/compiler/LocalLevelServiceObjectAnalysisTask.java Outdated Show resolved Hide resolved

Apply suggestions from code reviews

642e4b2

DimuthuMadushan reviewed Jan 10, 2024

View reviewed changes

...test/resources/ballerina_sources/generator_tests/25_local_graphql_service_object/service.bal Outdated Show resolved Hide resolved

ThisaruGuruge reviewed Jan 10, 2024

View reviewed changes

zetcco and others added 7 commits January 11, 2024 10:22

[Automated] Update the native jar versions

2cb2a88

[Automated] Update the native jar versions

2906fad

Use textRange to modify service declaration nodes

4aa10e1

Add support to generate schema for object field

04e8bc5

Remove unused test case resources

ed29c33

Merge branch 'master' into schema_from_local_service_obj

3b433c6

Add test case with distinct service class type

54f7a2f

DimuthuMadushan reviewed Jan 16, 2024

View reviewed changes

...resources/ballerina_sources/generator_tests/25_local_service_object_declarations/service.bal Outdated Show resolved Hide resolved

...es/ballerina_sources/generator_tests/26_object_field_service_object_declarations/service.bal Outdated Show resolved Hide resolved

Apply suggestions from code review

7472df0

MohamedSabthar reviewed Jan 17, 2024

View reviewed changes

.../test/resources/ballerina_sources/generator_tests/27_inline_service_declarations/service.bal Show resolved Hide resolved

ThisaruGuruge reviewed Jan 18, 2024

View reviewed changes

zetcco added 3 commits January 19, 2024 10:36

[Automated] Update the native jar versions

808548d

[Automated] Update the native jar versions

bdedebd

Add runtime tests

44684e5

ThisaruGuruge approved these changes Jan 22, 2024

View reviewed changes

ThisaruGuruge added 2 commits January 22, 2024 10:57

Merge branch 'master' into schema_from_local_service_obj

5cd0a20

Merge branch 'master' into schema_from_local_service_obj

121cb1c

ThisaruGuruge merged commit edcb9b1 into ballerina-platform:master Jan 22, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support to Generate GraphQL Schema for Local Service Variable Declaration #1704

Add Support to Generate GraphQL Schema for Local Service Variable Declaration #1704

zetcco commented Jan 9, 2024 •

edited

Loading

CLAassistant commented Jan 9, 2024 •

edited

Loading

codecov bot commented Jan 10, 2024 •

edited

Loading

ThisaruGuruge left a comment

sonarqubecloud bot commented Jan 22, 2024

Add Support to Generate GraphQL Schema for Local Service Variable Declaration #1704

Add Support to Generate GraphQL Schema for Local Service Variable Declaration #1704

Conversation

zetcco commented Jan 9, 2024 • edited Loading

Purpose

Examples

Checklist

CLAassistant commented Jan 9, 2024 • edited Loading

codecov bot commented Jan 10, 2024 • edited Loading

Codecov Report

ThisaruGuruge left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 22, 2024

Quality Gate passed

zetcco commented Jan 9, 2024 •

edited

Loading

CLAassistant commented Jan 9, 2024 •

edited

Loading

codecov bot commented Jan 10, 2024 •

edited

Loading